Fix BiologicsReportTest - don't offer files with no content#7250
Merged
labkey-jeckels merged 1 commit intodevelopfrom Dec 8, 2025
Merged
Fix BiologicsReportTest - don't offer files with no content#7250labkey-jeckels merged 1 commit intodevelopfrom
labkey-jeckels merged 1 commit intodevelopfrom
Conversation
labkey-alan
approved these changes
Dec 8, 2025
Contributor
labkey-alan
left a comment
There was a problem hiding this comment.
This looks good to me, but as you noted, it does seem odd that we're even creating empty files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
The recent FileLike refactor broke the BiologicsReportTest by offering up R output files that didn't actually get generated. We've been creating 0 byte output files and then opt not to serve them to the client. This restores that behavior. As a followup, we might avoid creating these files in the first place.
Changes
Tasks 📍