Query customizer for HL7 Pivot tables #881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request adds calculated at-time columns (assignments and accounts) and age columns to HL7 Pivot tables through both Java customizer code and query XML configuration changes. It also introduces a composite key field for each pivot table and creates a new query view (qview) for routine chemistry results.
Changes:
- Added Java customizer logic to append assignment and age calculated columns to HL7 pivot tables
- Added composite key fields (id + date concatenation) to all HL7 pivot table SQL queries
- Configured key field metadata and added DefaultEHRCustomizer to all HL7 pivot table query.xml files
- Created a new RoutineChemistry.qview.xml file with specific column selections for biochemistry results
- Applied ltrim/rtrim to TestName in HL7BiochemistryPivot for whitespace handling
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 19 comments.
Show a summary per file
| File | Description |
|---|---|
| SNPRC_EHRCustomizer.java | Added logic to detect HL7 pivot tables and append assignment and age calculated columns |
| HL7BiochemistryPivot.sql | Added key field and trimmed TestName in the IN clause |
| HL7BiochemistryPivot.query.xml | Added DefaultEHRCustomizer and key field configuration |
| HL7CulturePivot.sql | Added key field composed of id and date |
| HL7CulturePivot.query.xml | Added DefaultEHRCustomizer and key field configuration |
| HL7HematologyPivot.sql | Added key field composed of id and date |
| HL7HematologyPivot.query.xml | Added DefaultEHRCustomizer and key field configuration |
| HL7HistologyPivot.sql | Added key field composed of id and date |
| HL7HistologyPivot.query.xml | Added DefaultEHRCustomizer and key field configuration |
| HL7MiscPivot.sql | Added key field composed of id and date |
| HL7MiscPivot.query.xml | Added DefaultEHRCustomizer and key field configuration |
| HL7ParasitologyPivot.sql | Added key field composed of id and date |
| HL7ParasitologyPivot.query.xml | Added DefaultEHRCustomizer and key field configuration |
| HL7SurveillancePivot.sql | Added key field but with incorrect column references |
| HL7SurveillancePivot.query.xml | Added DefaultEHRCustomizer and key field configuration |
| HL7UnknownPivot.sql | Added key field composed of id and date |
| HL7UnknownPivot.query.xml | Added DefaultEHRCustomizer and key field configuration |
| HL7UrinalysisPivot.sql | Added key field composed of id and date |
| HL7Urinalysis.query.xml | Added DefaultEHRCustomizer and key field configuration |
| RoutineChemistry.qview.xml | New query view defining specific columns for routine chemistry results |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jallentxbiomed
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Added calculated at-time columns for assignments and accounts to HL7 Pivot tables. Started creating qviews for routine lab results.