Add link to "Register" for a new account #1173
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for a new account.
labkey-jeckels
requested changes
Jan 29, 2026
Contributor
labkey-jeckels
left a comment
labkey-jeckels
left a comment
There was a problem hiding this comment.
A couple of small requests.
Seems like we should add a basic test for this. We don't need to cover the self-registration case, but we could add to an existing test. Give guests access to the folder, logout, check that you can see a page or two, and that you get this prompt when you hit a blocked action.
| " to view this data"))); | ||
| "Login"), | ||
| " to view this data.", | ||
| DOM.BR(), |
Contributor
There was a problem hiding this comment.
I suggest conditionalizing this with a check to AuthenticationManager.isRegistrationEnabled(). Otherwise, on other servers it would send the user to a 404.
| @NotNull | ||
| private static HtmlView getLoginView(ViewContext context, Container container) | ||
| { | ||
| ActionURL registerUrl = new ActionURL("login", "register", container); |
Contributor
There was a problem hiding this comment.
I opened a PR to expose this via LoginUrls. Please switch to use that.
- Show "Register" link only if AuthenticationManager.isRegistrationEnabled() - Added test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
We will enable self-sign-up on PanoramaWeb. For pages that don't allow guest access, add a link to "Register" for an account in case the user does not have one.
Related Pull Requests