Skip to content

Add check to ensure the R process is ended successfully#2482

Merged
labkey-chrisj merged 5 commits intodevelopfrom
fb_chris_misc_issues
Jun 11, 2025
Merged

Add check to ensure the R process is ended successfully#2482
labkey-chrisj merged 5 commits intodevelopfrom
fb_chris_misc_issues

Conversation

@labkey-chrisj
Copy link
Contributor

@labkey-chrisj labkey-chrisj commented Jun 10, 2025

Rationale

This adds verification to AssayTransformImportUpdateTest.testCancelAsyncAssayTransformJob to ensure that canceling the job does in fact end it; during earlier testing we found that in some cases child processes of the initial R process could persist- Josh made changes in LabKey/platform#6740 that terminate these child processes appropriately.

Because this test case also falls afoul of Issue 53240 when run on SQL server, I've added an Assume call to prevent it from running on SQL until this issue can be sorted out appropriately. I've also marked up the issue to reflect this, to give future-us a cue to update this test when resolving it.

I've attempted to cancel the job from the pipeline list in the past, but I didn't see 'cancel' as an option (either it wasn't there, or I didn't see it). I'll try to do that again as a way to work around Issue 53240 that doesn't require not doing the test on SQL

Related Pull Requests

LabKey/platform#6740

Changes

Verify the duration between launch and done is less than how long it would take to complete unterminated

@labkey-chrisj
Copy link
Contributor Author

labkey-chrisj commented Jun 10, 2025

For context, this is what I'm seeing locally when I run this test on Windows/SQL up to the point that I click 'save and finish' for the assay import: no cancel option in the data pipeline list:
image

I did the same check on PG, with exactly the same result: no option to cancel.
This could be info relevant to Issue 53240? I'll add that to the issue.

@labkey-chrisj
Copy link
Contributor Author

Also for consideration: with Josh's changes in the related PR, the console spew includes this kind of information when cancelling a job:
image
I'm curious to know if our recent logging refactors might make it possible for tests to peek at the server log at times like this

@labkey-jeckels
Copy link
Contributor

For context, this is what I'm seeing locally when I run this test on Windows/SQL up to the point that I click 'save and finish' for the assay import: no cancel option in the data pipeline list: image

I did the same check on PG, with exactly the same result: no option to cancel. This could be info relevant to Issue 53240? I'll add that to the issue.

This is a difference in the job grid in the assay UI vs the pipeline UI. We could add the buttons here, or the test go to Gear->Go To Module->Pipeline

@labkey-jeckels
Copy link
Contributor

Also for consideration: with Josh's changes in the related PR, the console spew includes this kind of information when cancelling a job: image I'm curious to know if our recent logging refactors might make it possible for tests to peek at the server log at times like this

The recent logging changes don't really change this. The tests always had the option of looking at this through the Admin Console. Here's an example I just added:

ShowAdminPage adminPage = goToAdminConsole();

@labkey-chrisj labkey-chrisj merged commit 3d0ff6d into develop Jun 11, 2025
5 of 6 checks passed
@labkey-chrisj labkey-chrisj deleted the fb_chris_misc_issues branch June 11, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants