Add check to ensure the R process is ended successfully#2482
Merged
labkey-chrisj merged 5 commits intodevelopfrom Jun 11, 2025
Merged
Add check to ensure the R process is ended successfully#2482labkey-chrisj merged 5 commits intodevelopfrom
labkey-chrisj merged 5 commits intodevelopfrom
Conversation
labkey-tchad
approved these changes
Jun 10, 2025
Contributor
Author
Contributor
Author
Contributor
Contributor
labkey-jeckels
approved these changes
Jun 10, 2025
labkey-danield
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Rationale
This adds verification to
AssayTransformImportUpdateTest.testCancelAsyncAssayTransformJobto ensure that canceling the job does in fact end it; during earlier testing we found that in some cases child processes of the initial R process could persist- Josh made changes in LabKey/platform#6740 that terminate these child processes appropriately.Because this test case also falls afoul of Issue 53240 when run on SQL server, I've added an
Assumecall to prevent it from running on SQL until this issue can be sorted out appropriately. I've also marked up the issue to reflect this, to give future-us a cue to update this test when resolving it.I've attempted to cancel the job from the pipeline list in the past, but I didn't see 'cancel' as an option (either it wasn't there, or I didn't see it). I'll try to do that again as a way to work around Issue 53240 that doesn't require not doing the test on SQL
Related Pull Requests
LabKey/platform#6740
Changes
Verify the duration between launch and done is less than how long it would take to complete unterminated