Skip to content

Fix incorrect error log iteration#2486

Merged
labkey-tchad merged 1 commit intorelease25.6-SNAPSHOTfrom
25.6_fb_badErrorIterator
Jun 12, 2025
Merged

Fix incorrect error log iteration#2486
labkey-tchad merged 1 commit intorelease25.6-SNAPSHOTfrom
25.6_fb_badErrorIterator

Conversation

@labkey-tchad
Copy link
Member

Rationale

This loop makes an unnecessary call to iterator.next(). At best, this will skip a line we mean to log. At worst, we're at the end of the collection and it throws an exception.

java.util.NoSuchElementException
  at java.base/java.util.Spliterators$1Adapter.next(Spliterators.java:688)
  at org.labkey.test.LabKeySiteWrapper.checkErrors(LabKeySiteWrapper.java:975)

Related Pull Requests

  • N/A

Changes

  • Fix incorrect error log iteration

@labkey-tchad labkey-tchad requested review from a team and labkey-chrisj and removed request for a team June 11, 2025 17:54
@labkey-tchad labkey-tchad merged commit 9313f34 into release25.6-SNAPSHOT Jun 12, 2025
8 checks passed
@labkey-tchad labkey-tchad deleted the 25.6_fb_badErrorIterator branch June 12, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants