Add explicit test coverage for trigger script type conversion#2487
Merged
labkey-susanh merged 2 commits intodevelopfrom Jun 11, 2025
Merged
Add explicit test coverage for trigger script type conversion#2487labkey-susanh merged 2 commits intodevelopfrom
labkey-susanh merged 2 commits intodevelopfrom
Conversation
labkey-susanh
requested changes
Jun 11, 2025
| // | ||
| // _portalHelper.addWebPart("Datasets"); | ||
| // _portalHelper.addWebPart("Data Classes"); | ||
| // _portalHelper.addWebPart("Sample Types"); |
Contributor
There was a problem hiding this comment.
Is this meant to be commented out?
Contributor
Author
There was a problem hiding this comment.
On my dev machine, yes. In the repo, no. Now fixed.
labkey-susanh
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We want trigger scripts to have the ability to do custom parsing on incoming values. A recent change broke that, and we were somewhat lucky to catch it in another automated test. We'll benefit from more intentional coverage.
Related Pull Requests
Changes