Merged
Conversation
labkey-tchad
approved these changes
Jun 23, 2025
Member
labkey-tchad
left a comment
labkey-tchad
left a comment
There was a problem hiding this comment.
Consider adding getColumnNames and getColumnFieldKeys methods instead (similar to the existing getColumnLabels method). Tests are pretty much going to always map getHeaders into one of those. Might as well skip the step for them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This change exposes the recently-added
getHeaders()method onResponsiveGridto tests, such that they can resolve fields for which the test might only have fieldKeys or names. This will be helpful for tests using randomly-generated/tricky field names, as some tricky chars that are legal for field names but aren't in field labels can mean the field I created (either via UI or API) won't match any in the grid if what the grid shows in its headers is labels.Related Pull Requests
example usages are in https://github.com/LabKey/limsModules/pull/1481
Changes
Make
ResponsiveGrid.getHeaders()public