Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
7d0f40b
Add TRICKY_DOMAIN_NAME_CHARACTERS to BaseWebDriverTest.
labkey-danield Feb 7, 2025
0dc1a77
Merge branch 'develop' into fb_smFolderArchives
labkey-danield Feb 14, 2025
1b2ecc8
Merge branch 'develop' into fb_smFolderArchives
labkey-danield Feb 26, 2025
9e81a05
Merge branch 'develop' into fb_smFolderArchives
labkey-danield Feb 27, 2025
7ea1145
Merge branch 'develop' into fb_smFolderArchives
labkey-danield Feb 28, 2025
6e15b1c
Merge branch 'develop' into fb_smFolderArchives
labkey-danield Mar 4, 2025
f854af9
Merging develop into fb_smFolderArchives.
labkey-danield Jun 25, 2025
fdf8cd6
Fix some bad merge resolutions.
labkey-danield Jun 25, 2025
698fdba
Merge branch 'develop' into fb_smFolderArchives
labkey-danield Jul 2, 2025
fca78cf
Merge branch 'develop' into fb_smFolderArchives
labkey-danield Jul 7, 2025
51d8989
Merge branch 'develop' into fb_smFolderArchives
labkey-danield Jul 9, 2025
3eb2476
Merge branch 'develop' into fb_smFolderArchives
labkey-danield Jul 11, 2025
93eea03
Merge branch 'develop' into fb_smFolderArchives
labkey-danield Jul 14, 2025
a457d87
Merge branch 'develop' into fb_smFolderArchives
labkey-danield Jul 15, 2025
1b74b50
Merge branch 'develop' into fb_smFolderArchives
labkey-danield Jul 16, 2025
61c1963
Merge branch 'develop' into fb_smFolderArchives
labkey-danield Jul 17, 2025
4631f56
Merge branch 'develop' into fb_smFolderArchives
labkey-danield Jul 24, 2025
78ca5e3
Merge branch 'develop' into fb_smFolderArchives
labkey-danield Jul 24, 2025
fc3f097
Merge branch 'develop' into fb_smFolderArchives
labkey-danield Jul 28, 2025
7911108
Merge branch 'develop' into fb_smFolderArchives
labkey-danield Aug 4, 2025
1758e68
Merge branch 'develop' into fb_smFolderArchives
labkey-danield Aug 13, 2025
98f94ba
Merge branch 'develop' into fb_smFolderArchives
labkey-danield Aug 13, 2025
e28826a
Added tests for searching, filter and file import.
labkey-danield Aug 14, 2025
ff7fe0a
Merge branch 'develop' into fb_smFolderArchives
labkey-danield Aug 14, 2025
9741f8b
Merge branch 'develop' into fb_smFolderArchives
labkey-danield Aug 15, 2025
9a15007
Remove unneeded constant.
labkey-danield Aug 15, 2025
cc1cf09
Merge branch 'develop' into fb_smFolderArchives
labkey-danield Aug 15, 2025
69d0dd3
Merge remote-tracking branch 'origin/develop' into fb_smFolderArchives
labkey-tchad Aug 18, 2025
503d240
Change FolderArchiveDialog to extend ModalDialog and not DeleteConfir…
labkey-danield Aug 19, 2025
9cd0738
Merge branch 'develop' into fb_smFolderArchives
labkey-danield Aug 19, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/org/labkey/test/BaseWebDriverTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ public abstract class BaseWebDriverTest extends LabKeySiteWrapper implements Cle
public static final double DELTA = 10E-10;

public static final String ALL_ILLEGAL_QUERY_KEY_CHARACTERS = StringUtils.join(FieldKey.getIllegalChars(), "");
// See TSVWriter.shouldQuote. Generally we are not able to use the tab and new line characters when creating field names in the UI, but including here for completeness
// See TSVWriter.shouldQuote. Generally, we are not able to use the tab and new line characters when creating field names in the UI, but including here for completeness
public static final String[] TRICKY_IMPORT_FIELD_CHARACTERS = {"\\", "\"", "\\t", ",", "\\n", "\\r"};

public static final String TRICKY_CHARACTERS = "><&/%\\' \"1\u00E4\u00F6\u00FC\u00C5";
Expand Down
51 changes: 51 additions & 0 deletions src/org/labkey/test/components/ui/FolderArchiveDialog.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
package org.labkey.test.components.ui;

import org.jetbrains.annotations.NotNull;
import org.labkey.test.WebDriverWrapper;
import org.labkey.test.components.UpdatingComponent;
import org.labkey.test.components.bootstrap.ModalDialog;
import org.openqa.selenium.WebElement;
import org.openqa.selenium.support.ui.ExpectedConditions;

import java.util.function.Function;
import java.util.function.Supplier;

public class FolderArchiveDialog <ConfirmPage extends WebDriverWrapper> extends ModalDialog
{

private final Function<Runnable, ConfirmPage> _confirmationSynchronizationFunction;

public FolderArchiveDialog(@NotNull WebDriverWrapper sourcePage, WebElement staleOnConfirmElement, Supplier<ConfirmPage> confirmPageSupplier)
{

// Dialog finder stumbles with 'tricky characters' so limiting the search to just the word 'Archive'.
super(new ModalDialog.ModalDialogFinder(sourcePage.getDriver()).withTitleIgnoreCase("Archive"));

UpdatingComponent updatingComponent = runnable -> {
runnable.run();
sourcePage.longWait().until(ExpectedConditions.stalenessOf(staleOnConfirmElement));
};

_confirmationSynchronizationFunction = runnable -> {
updatingComponent.doAndWaitForUpdate(runnable);
return confirmPageSupplier.get();
};

}

public ConfirmPage clickYesArchive()
{
return clickYesArchive(10);
}

public ConfirmPage clickYesArchive(Integer waitSeconds)
{
return _confirmationSynchronizationFunction.apply(() -> this.dismiss( "Yes, Archive Folder", waitSeconds));
}

public void clickCancel()
{
this.dismiss("Cancel");
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ public FieldSelectionDialog insertColumn(CharSequence columnIdentifier)
return new FieldSelectionDialog(getDriver(), this);
}

protected void clickColumnMenuItem(CharSequence columnIdentifier, String menuText, boolean waitForUpdate)
public void clickColumnMenuItem(CharSequence columnIdentifier, String menuText, boolean waitForUpdate)
{

if(hasLockedColumn())
Expand Down
2 changes: 1 addition & 1 deletion src/org/labkey/test/components/ui/navigation/NavBar.java
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public abstract class NavBar extends WebDriverComponent<NavBar.ElementCache>

protected NavBar(WebDriver driver)
{
this(Locator.tagWithClass("nav", "navbar-container").findElement(driver), driver);
this(Locator.tagWithClass("nav", "navbar").findElement(driver), driver);
}

protected NavBar(WebElement element, WebDriver driver)
Expand Down
8 changes: 4 additions & 4 deletions src/org/labkey/test/components/ui/search/SampleFinder.java
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public WebDriver getDriver()
}

/**
* Waits for initial state (empty filter card panel) or for search results grid to appear
* Waits for the initial state (empty filter card panel) or for the search results grid to appear
*/
@Override
public void waitForReady()
Expand All @@ -70,10 +70,10 @@ public void waitForReady()
/**
* Open the entity filter dialog for the specified filter type.
*
* @param filterKind "Source" or "Parent" or "Assay" in SM. "Registry Parent" or "Sample Parent" or "Assay" in Biologics
* @param filterKind "Sample", "Source" or "Parent" or "Assay" in SM. "Registry Parent" or "Sample Parent" or "Assay" in Biologics
* @return component wrapper for the EntityFieldFilterModal
*/
public EntityFieldFilterModal clickAddParent(String filterKind)
public EntityFieldFilterModal clickAddSearchCard(String filterKind)
{
elementCache().findFilterKindButton(filterKind).click();
return new EntityFieldFilterModal(getDriver(), this::doAndWaitForUpdate);
Expand Down Expand Up @@ -110,7 +110,7 @@ public void removeSearchCard(String queryName)
}

/**
* Reset sample finder to its initial state, with no search criteria
* Reset the sample finder to its initial state, with no search criteria
*/
public void removeAllSearchCards()
{
Expand Down