Skip to content

Wait for participant report "Save" button to be enabled #2519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-tchad merged 2 commits into from
Jun 26, 2025
Merged

Wait for participant report "Save" button to be enabled #2519

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f98c98c
Wait for participant report "Save" button to be enabled
labkey-tchad Jun 26, 2025
098e319
Use existing locator to find enabled button
labkey-tchad Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions src/org/labkey/test/tests/ParticipantReportTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import org.labkey.test.categories.Reports;
import org.labkey.test.components.ext4.Window;
import org.labkey.test.components.html.BootstrapMenu;
import org.labkey.test.util.Ext4Helper;
import org.labkey.test.util.LogMethod;
import org.openqa.selenium.By;
import org.openqa.selenium.WebElement;
Expand Down Expand Up @@ -262,25 +263,28 @@ private void doParticipantReportTest()
waitForElementToDisappear(Locator.xpath("id('participant-report-panel-1-body')/div[contains(@style, 'display: none')]"), WAIT_FOR_JAVASCRIPT);
click(Locator.xpath("//img[@data-qtip = 'Delete']")); // Delete 'Severity Grade' column.
clickButton("Save As", 0);
_extHelper.waitForExtDialog("Save As");
Window<?> saveAsDialog = new Window.WindowFinder(getDriver()).withTitle("Save As").waitFor();
_extHelper.setExtFormElementByLabel("Save As", "Report Name", PARTICIPANT_REPORT2_NAME);
_extHelper.setExtFormElementByLabel("Save As", "Report Description", PARTICIPANT_REPORT2_DESCRIPTION);
clickButtonByIndex("Save", 1, 0);
Ext4Helper.Locators.ext4ButtonEnabled("Save").waitForElement(saveAsDialog, 2_000).click();
saveAsDialog.waitForClose();
_ext4Helper.waitForComponentNotDirty("participant-report-panel-1");
waitForTextToDisappear("Severity Grade");

// Verify saving with existing report name.
click(Locator.xpath("//a[./span[@title = 'Edit']]"));
waitForElementToDisappear(Locator.xpath("id('participant-report-panel-1-body')/div[contains(@style, 'display: none')]"), WAIT_FOR_JAVASCRIPT);
clickButton("Save As", 0);
_extHelper.waitForExtDialog("Save As");
saveAsDialog = new Window.WindowFinder(getDriver()).withTitle("Save As").waitFor();
_extHelper.setExtFormElementByLabel("Save As", "Report Name", PARTICIPANT_REPORT_NAME);
_extHelper.setExtFormElementByLabel("Save As", "Report Description", PARTICIPANT_REPORT2_DESCRIPTION);
clickButtonByIndex("Save", 1, 0);
_extHelper.waitForExtDialog("Failure");
Ext4Helper.Locators.ext4ButtonEnabled("Save").waitForElement(saveAsDialog, 2_000).click();
Window<?> failureDialog = new Window.WindowFinder(getDriver()).withTitle("Failure").waitFor();
assertTextPresent("Another report with the same name already exists.");
clickButton("OK", 0);
failureDialog.waitForClose();
clickButton("Cancel", 0); // Verify cancel button.
saveAsDialog.waitForClose();
waitForElement(Locator.xpath("id('participant-report-panel-1-body')/div[contains(@style, 'display: none')]"), WAIT_FOR_JAVASCRIPT); // Edit panel should be hidden


Expand Down Expand Up @@ -350,12 +354,12 @@ private void doParticipantReportTest()
{
assertTextPresent(ptid);

String base = "//td//a[text()='" + ptid + "']/../../..//td[contains(text(), 'Groups:')]/following-sibling::td[contains(normalize-space(), '";
waitForElement(Locator.xpath(base + PARTICIPANT_GROUP_ONE + "')]"));
Locator.XPathLocator base = Locator.xpath("//td//a[text()='" + ptid + "']/../../..//td[contains(text(), 'Groups:')]/following-sibling::td");
waitForElement(base.containing(PARTICIPANT_GROUP_ONE));

if (ptid_list2.contains(ptid))
{
assertElementPresent(Locator.xpath(base + PARTICIPANT_GROUP_TWO + "')]"));
assertElementPresent(base.containing(PARTICIPANT_GROUP_TWO));
}

}
Expand Down