Skip to content

Issue 52339: Change list domain URI construction to not use encoded user-provided names #2522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-susanh merged 3 commits into from
Jul 1, 2025
Merged

Issue 52339: Change list domain URI construction to not use encoded user-provided names #2522

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
47c684b
Issue 52339: Change list domain URI construction to not use encoded u…
labkey-susanh Jun 26, 2025
0bd7422
Merge remote-tracking branch 'origin/develop' into fb_domainLsids
labkey-susanh Jun 30, 2025
aaa9193
Merge remote-tracking branch 'origin/develop' into fb_domainLsids
labkey-susanh Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions src/org/labkey/test/tests/list/ListTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
import org.labkey.test.pages.ImportDataPage;
import org.labkey.test.pages.list.EditListDefinitionPage;
import org.labkey.test.pages.list.GridPage;
import org.labkey.test.pages.query.UpdateQueryRowPage;
import org.labkey.test.params.FieldDefinition;
import org.labkey.test.params.FieldDefinition.StringLookup;
import org.labkey.test.params.FieldInfo;
Expand Down Expand Up @@ -508,6 +509,32 @@ public void testNameTrimming()
checker().withScreenshot().verifyEquals("Name not trimmed as expected", trimmedName, editList.getName());
}

@Test // Issue 52339
public void testLongName()
{
String listName = "A_+-:''.¡™£¢∞§¶•ªº–≠œ∑´®†¥¨ˆøπ“‘«æ…¬˚∆˙©√ƒ∂ßΩ≈ç√∫µ≤≥÷‹›fifl‡°·‚—±⁄€‹›‡‰Æ«»¢∫√∑∏∂";
Copy link
Contributor

@XingY XingY Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider append a random string?

Copy link
Contributor Author

@labkey-susanh labkey-susanh Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems superfluous when the name is already ridiculously complex.

Copy link
Contributor

@XingY XingY Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps. It does lack certain pattern though, like whitespaces.

Copy link
Contributor

@labkey-danield labkey-danield Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think any of these need to be escaped to unicode \u values. Was that your impression as well?

Copy link
Contributor Author

@labkey-susanh labkey-susanh Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the list looks like it's as provided here. And, in any case, the particular characters are not all that important, just the fact that this leads to a really long URI encoded name.

String fieldWithDefault = TestDataGenerator.randomFieldName("With Default");
EditListDefinitionPage listEditPage = _listHelper.beginCreateList(getProjectName(), listName);
listEditPage.manuallyDefineFieldsWithAutoIncrementingKey("Key");
listEditPage.addField(new FieldDefinition(fieldWithDefault, ColumnType.String));
listEditPage.clickSave();

listEditPage = _listHelper.goToEditDesign(listName);
var page = listEditPage.getFieldsPanel()
.expand()
.getField(fieldWithDefault)
.clickAdvancedSettings()
.clickDefaultValuesLink();
var input = Locator.tagContainingText("td", "With Default").followingSibling("td").descendant("input").findElement(page.getDriver());
setFormElement(input, "42");
clickButton("Save Defaults");
_listHelper.beginAtList(getProjectName(), listName);

DataRegionTable list = new DataRegionTable("query", getDriver());
UpdateQueryRowPage updatePage = list.clickInsertNewRow();
checker().verifyEquals("Default value not as expected ", "42", updatePage.getTextInputValue(fieldWithDefault));
updatePage.submit();
}
/* Issue 51572: Bug with creating a new list by uploading a csv file in "UTF-8 with BOM" format
*/
@Test
Expand Down