Skip to content

Issue list default values shouldn't render in the detail views. #2525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-klum merged 7 commits into from
Jun 30, 2025
Merged

Issue list default values shouldn't render in the detail views. #2525

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8414acf
Don't allow unsupported MVFK XML overrides
labkey-klum Jun 17, 2025
7918427
Merge branch 'develop' into fb_issue_51695
labkey-klum Jun 24, 2025
90fba57
code review feedback
labkey-klum Jun 26, 2025
87fbaa7
Merge remote-tracking branch 'origin/develop' into develop
labkey-klum Jun 26, 2025
50592a4
Default values shouldn't render in detail views.
labkey-klum Jun 27, 2025
34fc070
Merge remote-tracking branch 'origin/develop' into develop
labkey-klum Jun 30, 2025
d3b695d
Merge branch 'develop' into fb_issue_53343
labkey-klum Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/org/labkey/test/tests/issues/IssuesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,8 @@ public void generalTest() throws Exception
fields.add(new FieldDefinition("Note", new FieldDefinition.StringLookup("lists", getLookupTableName("issues", "Note"))));
fields.add(new FieldDefinition("Module", new FieldDefinition.StringLookup("lists", getLookupTableName("issues", "Module"))));

fields.add(new FieldDefinition("StringWithDefault", FieldDefinition.ColumnType.String));

clickProject(getProjectName());
waitAndClickAndWait(Locator.linkContainingText(ISSUE_SUMMARY_WEBPART_NAME));
IssuesAdminPage adminPage = _issuesHelper.goToAdmin();
Expand All @@ -272,6 +274,14 @@ public void generalTest() throws Exception
}
clickButton("Save");

// configure a string field with a default value
adminPage = _issuesHelper.goToAdmin();
adminPage.getFieldsPanel().getField("StringWithDefault")
.clickAdvancedSettings()
.clickDefaultValuesLink(); // should land us in
setFormElement(Locator.input("stringWithDefault"), "StringWithDefault (default value)");
clickButton("Save Defaults");

clickProject(getProjectName());
waitAndClickAndWait(Locator.linkContainingText(ISSUE_SUMMARY_WEBPART_NAME));

Expand All @@ -295,6 +305,9 @@ public void generalTest() throws Exception
if (!isElementPresent(fifthStringLocator))
fifthStringLocator = Locator.name("myfifthstring");
selectOptionByText(fifthStringLocator, "Polonium");
// clear out the default value on insert
setFormElement(Locator.name("stringWithDefault"), "");

clickButton("Save");

// find issueId - parse the text from first space to :
Expand All @@ -305,6 +318,7 @@ public void generalTest() throws Exception
"Milestone", "My Integer", "My Second Integer", "My First String", "My Third String", "My Fourth String", "My Fifth String");
assertTextNotPresent("MySecondString", "My Second String");
assertElementPresent(Locator.linkWithText("http://www.issues.test"));
assertTextNotPresent("StringWithDefault", "StringWithDefault (default value)");

// ListAction
clickAndWait(Locator.linkWithText("Issues List"));
Expand Down Expand Up @@ -596,6 +610,8 @@ public void requiredFieldsTest()
@Test
public void viewSelectedDetailsTest()
{


DataRegionTable issuesTable = new DataRegionTable(ISSUE_LIST_REGION_NAME, getDriver());

issuesTable.setFilter("Status", "Has Any Value", null);
Expand Down