Avoid generating fields names with reserved substitution format patterns#2537
Merged
labkey-tchad merged 1 commit intorelease25.7-SNAPSHOTfrom Jul 9, 2025
Merged
Conversation
e.g. ":Date" or ":First"
labkey-tchad
requested review from
a team and
labkey-danield
and removed request for
a team
labkey-danield
approved these changes
Jul 8, 2025
| if (numStartChars > 0 && randomFieldName.charAt(numStartChars - 1) == ':' && | ||
| StringUtils.isAlpha(part.substring(0, 4))) // The shortest pattern is four characters (see org.labkey.api.util.SubstitutionFormat.getFormatNames) | ||
| { | ||
| String regenExclusion = Objects.requireNonNullElse(exclusion, "") + ":"; |
Contributor
There was a problem hiding this comment.
Interesting, didn't know about this. Learn something new every day.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
As more tests are being converted to use random field names, they are failing periodically because we generate random field names that conflict with reserved formats. The reserved formats are colons followed by strings that tests often use for field names (e.g. ":Date" or ":First"). This change replaces the ':' with another random character if it generates something that might cause trouble.
Related Pull Requests
Changes