Editable Grid Issues Needs Automation#2548
Merged
labkey-tchad merged 25 commits intodevelopfrom Jul 11, 2025
Merged
Conversation
…dsAutomation # Conflicts: # src/org/labkey/test/BaseWebDriverTest.java # src/org/labkey/test/components/ui/grids/FieldReferenceManager.java # src/org/labkey/test/tests/SampleTypeNameExpressionTest.java # src/org/labkey/test/util/data/TestDataUtils.java
labkey-danield
approved these changes
Jul 10, 2025
|
|
||
| log("Use a name expression using a field from the named parent, with parent type not encoded."); | ||
| nameExpressionBad = String.format("SNP_${genId}_${%s/$s}_${materialInputs/%s/%s}", parentAlias, PARENT_FIELD_CURLY_RIGHT_INT.getExpName(), PARENT_SAMPLE_TYPE, PARENT_FIELD_CURLY_LEFT.getName()); | ||
| nameExpressionBad = String.format("SNP_${genId}_${%s/%s}_${materialInputs/%s/%s}", parentAlias, PARENT_FIELD_CURLY_RIGHT_INT.getExpName(), PARENT_SAMPLE_TYPE, PARENT_FIELD_CURLY_LEFT.getName()); |
Contributor
There was a problem hiding this comment.
This bugs me, I should have caught this when I was in this code last week. The linter was clearly calling this out but I overlooked it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
[Story]
These are some minor test library improvements that facilitated the new editable grid tests.
Related Pull Requests
Changes
Contracthints toDeferredErrorCollector