Compare thumbnail files instead of stringifying them

[labkey-tchad]

Rationale

LevenshteinDistance was used for verifying thumbnail files because WebTestHelper.getHttpResponse subtly modifies the response.
We can compare the thumbnail precisely if we look at the actual bytes. AssertJ actually has a method for this, making TestFileUtils.getMD5Hash obsolete in record time.

java.lang.RuntimeException: java.nio.charset.MalformedInputException: Input length = 1
  at org.labkey.test.TestFileUtils.getFileContents(TestFileUtils.java:121)
  at org.labkey.test.TestFileUtils.getFileContents(TestFileUtils.java:107)
  at org.labkey.test.tests.SimpleModuleTest.verifyReportThumbnail(SimpleModuleTest.java:1228)
  at org.labkey.test.tests.SimpleModuleTest.doTestReportThumbnails(SimpleModuleTest.java:1184)
  at org.labkey.test.tests.SimpleModuleTest.doTestReports(SimpleModuleTest.java:1174)
  at org.labkey.test.tests.SimpleModuleTest.doVerifySteps(SimpleModuleTest.java:274)
  at org.labkey.test.tests.SimpleModuleTest.testSteps(SimpleModuleTest.java:259)

Related Pull Requests

• A couple more CSP enhancements #2530

Changes

• Compare thumbnail files instead of stringifying them