Skip to content

Misc test updates related to recent fuzz testing changes#2578

Merged
cnathe merged 3 commits intodevelopfrom
fb_miscFuzzFixes
Jul 24, 2025
Merged

Misc test updates related to recent fuzz testing changes#2578
cnathe merged 3 commits intodevelopfrom
fb_miscFuzzFixes

Conversation

@cnathe
Copy link
Contributor

@cnathe cnathe commented Jul 24, 2025

Rationale

  • FileAttachmentColumnTest update to comment out randomFieldName usage
  • InlineImagesListTest update to not use randomFieldName for list field labels
    • the test is checking for column width in the exported Excel file so fuzzing the label isn't helpful here
  • TextChoiceSampleTypeTest update for how tsv import values are quoted in bulk import
    • remove surrounding quotes added by the test case and instead include a double quote in the value

cnathe added 3 commits July 24, 2025 09:04
… labels

- the test is checking for column width in the exported Excel file so fuzzing the label isn't helpful here
@cnathe cnathe requested a review from labkey-danield July 24, 2025 14:12
@cnathe cnathe self-assigned this Jul 24, 2025
Comment on lines +96 to +97
// Issue 53505: enable use of randomFieldName when issue is fixed
//private static final FieldInfo LIST_ATTACHMENT_FIELD = new FieldInfo(TestDataGenerator.randomFieldName("File / Attachment"), ColumnType.Attachment);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you haven't done so already, can you add a comment to 53505 referencing this test and letting whoever fixes know they need to uncomment this line of code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@cnathe cnathe merged commit bd10c83 into develop Jul 24, 2025
9 checks passed
@cnathe cnathe deleted the fb_miscFuzzFixes branch July 24, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants