Skip to content

Fix an issue with NameExpressionTest when a "_" is used as a value. #2591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-danield merged 1 commit into from
Jul 30, 2025
Merged

Fix an issue with NameExpressionTest when a "_" is used as a value. #2591

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/org/labkey/test/tests/SampleTypeNameExpressionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,8 +675,10 @@ private void verifyNames(String sampleTypeName, String header, String nameExpres
DataRegionTable materialTable = new DataRegionTable("Material", this);
List<String> names = materialTable.getColumnDataAsText("Name");

// The next two lines assume the name expression has specific values in specific locations, and as far as I
// can tell, that is how the tests are written.
assertTrue("First name (" + names.get(0) + ") expected to start with " + defaultValue + "_ but it did not", names.get(0).startsWith(defaultValue + "_"));
String batchRandomId = names.get(0).split("_")[1];
String batchRandomId = names.get(0).substring(names.get(0).lastIndexOf("_") + 1);

assertEquals("Second name not as expected", name2 + "_" + batchRandomId, names.get(1));

Expand Down