Skip to content

Conversation

@labkey-nicka
Copy link
Contributor

@labkey-nicka labkey-nicka commented Aug 7, 2025

Rationale

When using AuditLogHelper in testing it can result in an OOB exception that prevent the test from continuing. Instead, perform checks for length and return null otherwise.

image

Related Pull Requests

Changes

  • Update getLastDomainEvent() and getLastDomainEventId() to return null instead of throwing an OOB exception
  • Make getDomainAuditEventLog() filter for the domain name directly. Consistent with getDomainPropertyEventLog(). Requires case-sensitive domain name.
  • Update getDomainAuditEventLog() to support specifying a maxRows argument. Utilized when finding last audit event.

@labkey-nicka labkey-nicka requested a review from XingY August 7, 2025 17:56
@labkey-nicka labkey-nicka self-assigned this Aug 7, 2025
@labkey-nicka labkey-nicka merged commit 06c4adc into release25.7-SNAPSHOT Aug 11, 2025
8 checks passed
@labkey-nicka labkey-nicka deleted the 25.7_fb_audit_helper branch August 11, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants