AuditLogHelper: return null instead of index error #2610
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
When using
AuditLogHelperin testing it can result in an OOB exception that prevent the test from continuing. Instead, perform checks for length and return null otherwise.Related Pull Requests
Changes
getLastDomainEvent()andgetLastDomainEventId()to return null instead of throwing an OOB exceptiongetDomainAuditEventLog()filter for the domain name directly. Consistent withgetDomainPropertyEventLog(). Requires case-sensitive domain name.getDomainAuditEventLog()to support specifying amaxRowsargument. Utilized when finding last audit event.