Wait for panel visibility in ShowAdminPage

[labkey-tchad]

Rationale

Waiting for the selected admin tab to be visible should fix this intermittent test failure.

org.openqa.selenium.NoSuchElementException: Expected condition failed: waiting for link=Export Diagnostics (tried for 2 second(s) with 100 milliseconds interval)
  at app//org.labkey.test.Locator.waitForElement(Locator.java:561)
  at app//org.labkey.test.Locator.waitForElement(Locator.java:537)
  at app//org.labkey.test.Locator.waitForElement(Locator.java:530)
  at app//org.labkey.test.WebDriverWrapper.waitForElement_aroundBody10(WebDriverWrapper.java:2448)
  at app//org.labkey.test.WebDriverWrapper$AjcClosure11.run(WebDriverWrapper.java:1)
  at app//org.aspectj.runtime.reflect.JoinPointImpl.proceed(JoinPointImpl.java:164)
  at app//org.labkey.test.aspects.StaleElementRetryAspect.beforeLoggedMethod(StaleElementRetryAspect.java:40)
  at app//org.labkey.test.WebDriverWrapper.waitForElement(WebDriverWrapper.java:2446)
  at app//org.labkey.test.tests.cloudServices.ExportDiagnosticsTest.testPremiumLinksRegistered(ExportDiagnosticsTest.java:59)

Additionally, ShowAdminPage is unnecessarily verbose and repetitive. There is no need to cache any of the settings links, they are only ever clicked to navigate away from the page. We can also pull some shared functionality out of all the methods that click settings links.

Related Pull Requests

• N/A

Changes

• Wait for tabs to become visible in ShowAdminPage
• Remove unnecessary items from element cache