Skip to content

Conversation

@labkey-tchad
Copy link
Member

Rationale

  1. doAndWaitForWindow was implemented incorrectly. It needs to switch to the named window before calling doAndMaybeWaitForPageToLoad so that the page load is correctly detected.
  2. When updating TestDataGenerator.getDefaultDataSupplier to generate random data for textChoice fields, I assumed that we weren't generating random data for other field types with a conceptURI. We are generating random values for some Sample columns so I've restored the old behavior for other column types.

Related Pull Requests

Changes

  • Switch to target window before waiting for page load
  • Fix random data generation for sample fields

@labkey-tchad
Copy link
Member Author

labkey-tchad commented Aug 14, 2025

@labkey-tchad labkey-tchad merged commit 4324a20 into release25.7-SNAPSHOT Aug 15, 2025
7 checks passed
@labkey-tchad labkey-tchad deleted the 25.7_fb_fixTextFailures branch August 15, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants