Test Fixes for LKS Sample Type Test #2634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XingY
approved these changes
Aug 15, 2025
XingY
reviewed
Aug 15, 2025
| // Issue 53548: Naming Pattern with a default value containing a () or {} cannot be saved. | ||
| private static final String DEFAULT_SAMPLE_PARENT_VALUE = "SS" + | ||
| EscapeUtil.escapeForNameExpression(TestDataGenerator.randomString(3)); | ||
| EscapeUtil.escapeForNameExpression(TestDataGenerator.randomString(3, "{}()")); |
Contributor
There was a problem hiding this comment.
I also included '_' underscore character as excluded charset due to it being used in split
Contributor
Author
There was a problem hiding this comment.
Added "_" as well.
XingY
added a commit
that referenced
this pull request
Aug 15, 2025
# Conflicts: # src/org/labkey/test/tests/SampleTypeNameExpressionTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Addressing some random failures in Community.
Related Pull Requests
Changes