Fix domain/field name validation for trial tests #2658
Conversation
|
|
||
| private static boolean isDomainAndFieldNameInvalid(DomainUtils.DomainKind domainKind, @Nullable String domainName, @Nullable String fieldName) | ||
| { | ||
| if (TestProperties.isTrialServer()) // WebTestHelper.getRemoteApiConnection() won't work against trial server |
There was a problem hiding this comment.
I assume this doesn't work due to authentication issues.
Could we make the ValidateDomainAndFieldNames API available to guests? I see it's also a MutatingApiAction which surprised me. @cnathe are we close to being able to make this a ReadOnlyApiAction and/or open to guests?
There was a problem hiding this comment.
Having ValidateDomainAndFieldNames be a MutatingApiAction instead of ReadOnlyApiAction was inadvertant, copy-paste / typo on my part. I'll get that switched and a PR open.
There was a problem hiding this comment.
Do we need this change if/when Cory's change is merged?
There was a problem hiding this comment.
Not this change, but we would need to change isDomainAndFieldNameInvalid to use a guest connection instead of WebTestHelper.getRemoteApiConnection().
4 participants
Rationale
We can't validate random field and domain names when running against trial instances. We can do a test-side validation to get largely the same result.
Related Pull Requests
Changes