Skip to content

Conversation

@labkey-jeckels
Copy link
Contributor

Rationale

We haven't been properly handling nulls in issue API calls for custom fields, especially when they're required.

Related Pull Requests

Changes

  • Ensure that Java API call sends nulls
  • New test coverage to try various combinations of not sending properties and sending with nulls

@labkey-jeckels labkey-jeckels self-assigned this Aug 29, 2025
@labkey-jeckels
Copy link
Contributor Author

@labkey-klum as a repro case, here's a wiki I created to bulk resolve/close issues. It operates on the selected issues from the grid view. It failed on labkey.org due to problems with required custom fields. Repro steps:

https://www.labkey.org/home/Developer/issues/wiki-page.view?name=Bulk%20Issue%20Resolver

  1. Create an issue definition.
  2. Add a custom field, making it required.
  3. Insert an issue through the UI.
  4. Select the issue in the grid view.
  5. Go to the wiki (copied locally). Click to resolve/close.
  6. Ensure the issue gets resolved and then closed, and then custom field's value is preserved.

Copy link
Contributor

@labkey-klum labkey-klum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like your platform changes are breaking the IssueAPITest. The test appears to be relying on the previous behavior where null values were being ignored during validation.

The helper method : basicIssueModel probably shouldn't be used much in the update case.

@labkey-jeckels
Copy link
Contributor Author

Sure enough. Updates pushed. I will likely need to retarget to 25.9 but let's see what TC thinks first.

@labkey-jeckels labkey-jeckels deleted the fb_issueProperties branch September 3, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants