Make LinkedReportTest more robust #2662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-tchad
approved these changes
Sep 2, 2025
Comment on lines
43
to
49
| public void testLinkedReportToExternalURL() throws InterruptedException | ||
| { | ||
| goToProjectHome(); | ||
| goToManageViews().clickAddReport("Link Report"); | ||
| setFormElement(Locator.name("viewName"), REPORT_NAME); | ||
| setFormElement(Locator.name("linkUrl"), LINK_REPORT_URL); | ||
| Thread.sleep(1000); // Hack to prevent saving before the form is ready to submit, lacking a way to check before clicking |
Member
There was a problem hiding this comment.
WebDriverWrapper has a sleep method that wraps the InterruptedException automatically.
Suggested change
| public void testLinkedReportToExternalURL() throws InterruptedException | |
| { | |
| goToProjectHome(); | |
| goToManageViews().clickAddReport("Link Report"); | |
| setFormElement(Locator.name("viewName"), REPORT_NAME); | |
| setFormElement(Locator.name("linkUrl"), LINK_REPORT_URL); | |
| Thread.sleep(1000); // Hack to prevent saving before the form is ready to submit, lacking a way to check before clicking | |
| public void testLinkedReportToExternalURL() | |
| { | |
| goToProjectHome(); | |
| goToManageViews().clickAddReport("Link Report"); | |
| setFormElement(Locator.name("viewName"), REPORT_NAME); | |
| setFormElement(Locator.name("linkUrl"), LINK_REPORT_URL); | |
| sleep(1000); // Hack to prevent saving before the form is ready to submit, lacking a way to check before clicking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
LinkedReportTest can be flaky, especially when run solo, because it clicks on Save before the form is ready to process it.
Changes
Thread.sleep()since we lack a way to ask the form if it's ready