Update Amounts and Units for better sorting and filtering behavior#2678
Merged
Update Amounts and Units for better sorting and filtering behavior#2678
Conversation
…mount or unit, successful conversion, success insert/update/import)
labkey-danield
approved these changes
Sep 12, 2025
Comment on lines
+2074
to
+2080
| G("g", "g (grams)"), | ||
| MG("mg", "mg (milligrams)"), | ||
| KG("kg", "kg (kilograms)"), | ||
| ML("mL", "mL (milliliters)"), | ||
| UL("uL", "uL (microliters)"), | ||
| L("L", "L (liters)"), | ||
| UNIT("unit", "unit"); |
Contributor
There was a problem hiding this comment.
There is InventoryMetricUnit enum class in the Inventory module. Maybe that should be pulled out to the TestAutomation module?
I don't think you need to change this, just tossing an idea out.
Contributor
Author
There was a problem hiding this comment.
Yes, I think InventoryMetricUnit should be moved to testAutomation next to the interface it implements. But I am going to hold off an make that change in a separate PR since there are a lot of usages and I want to reduce the churn on this current PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
See platform PR for rationale.
This PR adds some new test cases for the amounts/units updates, especially in LKS grid cases.
Related Pull Requests
Changes