Update tests to stop using controller-first URLs #2681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-tchad
requested review from
a team,
labkey-chrisj and
labkey-danield
and removed request for
a team
labkey-danield
approved these changes
Sep 11, 2025
| // Verify Issue 16243: Details URL creating URLs with null container unless the container column is actually added to current view | ||
| log("** Removing container column and rechecking lookup URLs..."); | ||
| beginAt("/query/" + getProjectName() + "/executeQuery.view?schemaName=vehicle&query.queryName=EmissionTest&query.sort=RowId"); | ||
| ExecuteQueryPage queryPage = ExecuteQueryPage.getPageFactory("vehicle", "EmissionTest") |
Contributor
There was a problem hiding this comment.
Is this queryPage object used anyplace?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Controller-first URLs are now deprecated; tests should also stop using them. Specifically, tests should use
WebTestHelper.buildURLto create URLs that match the preferred server format.Related Pull Requests
Changes