Merged
Conversation
Simpler selectors.
Use a valid domain name in SMSampleTypeDesignerTest.testParentAndSourceAliasOptions Change the order of clearing the filters and selections in SMProMoveAssayRunsTest.configureGrid
XingY
reviewed
Oct 1, 2025
| while (iterator.hasNext()) { | ||
| String sampleName = iterator.next(); | ||
|
|
||
| json.append("\""); |
Contributor
There was a problem hiding this comment.
Could use EscapeUtil.toJSONStr
Dismissing banner messages after moving assay runs. Using EscapeUtil.toJSONStr to build json string. Added BannerHelper.dismissAllBannerMessages
XingY
approved these changes
Oct 2, 2025
labkey-susanh
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Fixing some tesst issue
Related Pull Requests
Changes