DetailTableEdit save and cancel buttons to include withText() in Locator#2720
Merged
DetailTableEdit save and cancel buttons to include withText() in Locator#2720
Conversation
labkey-danield
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
SMEditableGridTest.testEditLookupNotFound randomly fails when trying to click the Cancel button on the detail edit panel. This is because when it randomly creates fields for the source type, it will occasionally include a date/time field. This field type includes a little "X" icon/button in the input field display which is used to clear the value in the input. The Locator for the cancel button is just looking for a "button" tag, which ends up clicking the date/time input clear icon/button.
Changes