increment number to account for attachment as well as wiki#2724
Merged
labkey-chrisj merged 2 commits intodevelopfrom Oct 4, 2025
Merged
increment number to account for attachment as well as wiki#2724labkey-chrisj merged 2 commits intodevelopfrom
labkey-chrisj merged 2 commits intodevelopfrom
Conversation
Contributor
Author
labkey-danield
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
WikiTest.testSteps is failing because when new test method testDeleteUndeleteAttachment() leaves a saved attachment in the newly-created wiki, that attachment is indexed separately and appears as a search result when testSteps() searches and expects to find a specific number of results.
This change increments that counter by one to account for the new attachment in addition to the new wiki created by the test