Add EscapeUtil.escapeForExcelSheetName#2726
Merged
labkey-danield merged 3 commits intodevelopfrom Oct 7, 2025
Merged
Conversation
Call EscapeUtil.escapeForExcelSheetName in SMProSamplesCrossFolderCRUDTest.testUniqueSheetNamesForLongTypeNames
labkey-tchad
reviewed
Oct 6, 2025
Comment on lines
228
to
231
| public static String escapeForExcelSheetName(String value) | ||
| { | ||
| return excelPageNeedsEscaping.matcher(value).replaceAll("_"); | ||
| } |
Member
There was a problem hiding this comment.
There's an existing, more thorough method for this (it's what is used on the server side). org.apache.poi.ss.util.WorkbookUtil#createSafeSheetName(java.lang.String, char)
Suggested change
| public static String escapeForExcelSheetName(String value) | |
| { | |
| return excelPageNeedsEscaping.matcher(value).replaceAll("_"); | |
| } | |
| public static String createSafeSheetName(String value) | |
| { | |
| return WorkbookUtil.createSafeSheetName(value, '_'); | |
| } |
Also, this isn't escaping (escaping is reversible). Consider moving this method to ExcelHelper.
labkey-tchad
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Add EscapeUtil.escapeForExcelSheetName to replace : / with _ when looking at sheet names in excel.
Related Pull Requests
Changes