refactor testLongName to use FieldInfo#2737
Merged
labkey-chrisj merged 2 commits intorelease25.7-SNAPSHOTfrom Oct 9, 2025
Merged
refactor testLongName to use FieldInfo#2737labkey-chrisj merged 2 commits intorelease25.7-SNAPSHOTfrom
labkey-chrisj merged 2 commits intorelease25.7-SNAPSHOTfrom
Conversation
labkey-susanh
approved these changes
Oct 8, 2025
labkey-tchad
approved these changes
Oct 8, 2025
labkey-tchad
requested changes
Oct 8, 2025
Comment on lines
548
to
549
| var input = Locator.tagContainingText("td", fieldWithDefault.getName()).followingSibling("td") | ||
| .descendant("input").findElement(page.getDriver()); |
Member
There was a problem hiding this comment.
I think this does want the label.
Suggested change
| var input = Locator.tagContainingText("td", fieldWithDefault.getName()).followingSibling("td") | |
| .descendant("input").findElement(page.getDriver()); | |
| var input = Locator.tagContainingText("td", fieldWithDefault.getLabel()).followingSibling("td") | |
| .descendant("input").findElement(page.getDriver()); |
The failure here is because in 25.7 there is an off-by-one error in the random name generator that sometimes trims the first character from the name part. The failure screenshot shows the field "안(и@ith Default?"; note the missing "W".
Contributor
Author
There was a problem hiding this comment.
Thank you!
I'd spotted the discrepancy between label and namePart, didn't remember that this was resolved later.
I'm assuming the more-general fix would be painful to backport? If you think it's worth doing, I'm willing to do that as well
Co-authored-by: Trey Chadick <tchad@labkey.com>
labkey-tchad
approved these changes
Oct 8, 2025
Contributor
Author
|
waiting for a successful TC run before merging https://teamcity.labkey.org/buildConfiguration/LabKey_257Release_Community_DailySuites_DailyDPostgres/3692836 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Recently, ListTest.testLongName failed because it couldn't find a UI field based on the namePart given to generate a random field. This change refactors the test to use a FieldInfo and refer to it for field information
Related Pull Requests
n/a