Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/org/labkey/test/tests/AttachmentFieldTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,9 @@ public void testFileFieldInSampleType()

clickAndWait(Locator.tagWithText("a", "S1"));
clickAndWait(Locator.tagWithClass("a", "labkey-text-link").withText("edit"));
waitForElement(Locator.tagContainingText("div", "sampletype/jpg_sample.jpg"));
waitForElement(Locator.tagContainingText("div", "jpg_sample.jpg"));
// Issue 53200: Update form incorrectly shows that a file is not available
assertTextNotPresent("sampletype/jpg_sample.jpg (unavailable)");
assertTextNotPresent("jpg_sample.jpg (unavailable)");
clickButton("Cancel");

log("Verifying view in browser works");
Expand Down
4 changes: 2 additions & 2 deletions src/org/labkey/test/tests/FileAttachmentColumnTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -613,7 +613,7 @@ private void validateAssayRun(String assayName, String folderPath, String runNam
checker().withScreenshot("unexpected_run_file_links")
.wrapAssertion(()-> Assertions.assertThat(runFileTexts.stream().map(String::trim).toList())
.as("expect complete run files")
.containsOnly(String.format("assaydata%s%s", File.separatorChar, runFile.getName()))
.containsOnly(runFile.getName())
.hasSize(5));
}

Expand All @@ -637,7 +637,7 @@ private void validateDatasetData(String datasetName, String folderPath, List<Fil
}
else
{
Optional<WebElement> optionalFileLink = Locator.linkContainingText(String.format("datasetdata%s%s", File.separatorChar, file.getName()))
Optional<WebElement> optionalFileLink = Locator.linkContainingText(file.getName())
.findOptionalElement(dataRegionTable);
checker().withScreenshot("unexpected_file_state")
.awaiting(Duration.ofSeconds(2),
Expand Down
9 changes: 3 additions & 6 deletions src/org/labkey/test/tests/InlineImagesAssayTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -182,10 +182,7 @@ public final void testAssayInlineImages() throws Exception
customizeView.addColumn(FieldKey.fromParts("Run", "RowId"));
customizeView.addColumn(FieldKey.fromParts("Run", "Protocol", "RowId"));
customizeView.applyCustomView();
var protocolId = list.getDataAsText(0, "Run/Protocol/RowId");
var runId = list.getDataAsText(0, "Run/RowId");
String helpJpgFilePath = String.format("AssayId_%s%sRunId_%s%s%s", protocolId, File.separatorChar,
runId, File.separatorChar, HELP_JPG_FILE.getName());
String helpJpgFilePath = HELP_JPG_FILE.getName();

log("Validate that two links to this image file are now present.");
assertElementPresent("Did not find the expected number of icons for images for " + PNG01_FILE.getName() + " from the runs.", Locator.xpath("//img[contains(@title, '" + PNG01_FILE.getName() + "')]"), 3);
Expand All @@ -206,7 +203,7 @@ public final void testAssayInlineImages() throws Exception

log("Validate that the 'File' (last) column is as expected.");
assertEquals("Values in 'File' column not exported as expected [" + exportedFile.getName() + "]",
Arrays.asList("Batch File Field", "assaydata" + File.separator + XLS_FILE.getName(), "assaydata" + File.separator + XLS_FILE.getName(), "assaydata" + File.separator + XLS_FILE.getName()),
Arrays.asList("Batch File Field", XLS_FILE.getName(), XLS_FILE.getName(), XLS_FILE.getName()),
ExcelHelper.getColumnData(workbook.getSheetAt(workbook.getActiveSheetIndex()), 7));
}

Expand Down Expand Up @@ -286,7 +283,7 @@ private void validateExcelExport(File exportedFile, Workbook workbook, String he

exportedColumn = ExcelHelper.getColumnData(sheet, 5);
assertEquals("Values in 'File' column not exported as expected [" + exportedFile.getName() + "]",
Arrays.asList("Run File Field", "assaydata" + File.separator + PNG01_FILE.getName(), "assaydata" + File.separator + PNG01_FILE.getName(), "assaydata" + File.separator + PNG01_FILE.getName()),
Arrays.asList("Run File Field", PNG01_FILE.getName(), PNG01_FILE.getName(), PNG01_FILE.getName()),
exportedColumn);

}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ public void testRTransformWarning()
clickAndWait(Locator.linkWithText(runName), longWaitForPage);

// Verify file uploaded
assertTextPresent("assaydata" + File.separator + JAVA_TRANSFORM_SCRIPT.getName(), 1);
assertTextPresent(JAVA_TRANSFORM_SCRIPT.getName(), 1);

DataRegionTable table = new DataRegionTable("Data", this);
assertEquals(1, table.getDataRowCount());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ public void testAllowedFileExtensionsInSampleType()
{
fieldMap = Map.of("Name", String.format("S-%d", i), stFileField, fileMap.get(allowedType).getAbsolutePath());
sampleTypeHelper.insertRow(fieldMap);
expectedValues.add(String.format(" sampletype%s%s", File.separator, fileMap.get(allowedType).getName()));
expectedValues.add(String.format(" %s", fileMap.get(allowedType).getName()));
i++;
}

Expand Down