Conversation
This was referenced Oct 16, 2025
cnathe
approved these changes
Oct 17, 2025
labkey-tchad
approved these changes
Oct 17, 2025
Comment on lines
+105
to
+109
| public QueryChartPanelFinder(WebDriver driver, QueryGrid queryGrid, String name) | ||
| { | ||
| super(driver); | ||
| _queryGrid = queryGrid; | ||
| _name = name; |
Member
There was a problem hiding this comment.
The chart name shouldn't be mandatory. The finder should find all of the charts by default and there should be a withName method to specify the name.
QueryChartPanel should probably have a getName method too.
Contributor
Author
There was a problem hiding this comment.
But if we only ever want to find a chart by name, then why should it find all by default? Put another way, why make a default that isn't used? Same goes for QueryChartPanel, why add a getName method that isn't used?
Member
There was a problem hiding this comment.
That's a fair point, I was mostly commenting on the typical design of component finders. If we ever have other needs for this, refactoring the finder is easy enough.
labkey-alan
force-pushed
the
fb_multi_chart_rendering
branch
from
b7671f6 to
1570fd7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This PR adds the necessary infrastructure to test for multiple charts on a grid
Related Pull Requests
Changes