Skip to content

Fixes for Windows failures after FileLike refactor#2780

Merged
labkey-jeckels merged 2 commits intorelease25.11-SNAPSHOTfrom
25.11_fb_windowsFileLikeFixes
Nov 9, 2025
Merged

Fixes for Windows failures after FileLike refactor#2780
labkey-jeckels merged 2 commits intorelease25.11-SNAPSHOTfrom
25.11_fb_windowsFileLikeFixes

Conversation

@labkey-jeckels
Copy link
Contributor

Rationale

https://teamcity.labkey.org/buildConfiguration/LabKey_2511Release_Premium_CommunitySqlserver_DailyASqlserver/3728152

Changes

  • Choose a pipeline root that encompasses all of the files being referenced

@labkey-jeckels labkey-jeckels self-assigned this Nov 8, 2025
@github-actions
Copy link

github-actions bot commented Nov 8, 2025

ERROR: A pull request from 25.11_fb_windowsFileLikeFixes is expected to target release25.11-SNAPSHOT, not develop

@labkey-jeckels labkey-jeckels changed the base branch from develop to release25.11-SNAPSHOT November 8, 2025 00:11
@labkey-jeckels
Copy link
Contributor Author

Copy link
Member

@labkey-tchad labkey-tchad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this only failing on Windows; shouldn't Linux fail in the same way?
Does this indicate that there is a backwards compatibility issue with XAR file import?

@labkey-jeckels
Copy link
Contributor Author

Why is this only failing on Windows; shouldn't Linux fail in the same way? Does this indicate that there is a backwards compatibility issue with XAR file import?

Yes, it should, but there was a problem related to / vs \ so we skipped an intended check on non-Windows. Fixed in the related platform PR.

@labkey-jeckels
Copy link
Contributor Author

Why is this only failing on Windows; shouldn't Linux fail in the same way? Does this indicate that there is a backwards compatibility issue with XAR file import?

As for backwards compatibility, yes, there's a potential concern, but hopefully not in the real world. The test was setting pipeline root in a place that didn't cover the whole tree of imported files, which shouldn't be common.

@labkey-jeckels labkey-jeckels merged commit f029d70 into release25.11-SNAPSHOT Nov 9, 2025
6 checks passed
@labkey-jeckels labkey-jeckels deleted the 25.11_fb_windowsFileLikeFixes branch November 9, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants