Conversation
dariocazzani
reviewed
Sep 4, 2025
| default="cuda", | ||
| choices=["cuda", "cpu"], | ||
| ) | ||
| parser.add_argument( |
Contributor
There was a problem hiding this comment.
I think the split should go in the config
dariocazzani
reviewed
Sep 4, 2025
| "--dtype", | ||
| type=str, | ||
| default=None, | ||
| help="NumPy dtype for pre-tokenized .bin files (e.g., 'uint16'). Required if using a .bin file.", |
Contributor
There was a problem hiding this comment.
How does one know the numpy type?
If using the cached bin file is favorable, it should be default behavior, and generate a new one if it's not present
Contributor
Author
There was a problem hiding this comment.
It does work exactly like you are expecting here. Preprocess data function ensures the right dtype is chosen based on the tokenizer. In case you are starting the initial training with a bin file then it won't know the type and needs the user to say what it is.
Contributor
|
If we use a |
Contributor
Author
|
These changes have been subsumed by #12. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a few optimizations: