[PLT-1725] Changed ontology dataclasses to pydantic dataclasses#1910
Closed
[PLT-1725] Changed ontology dataclasses to pydantic dataclasses#1910
Conversation
597095c to
46fe4d1
Compare
46fe4d1 to
378f851
Compare
7b4070c to
1db6a3e
Compare
vbrodsky
reviewed
Jan 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For example for this code:
class_typeandnameis given the wrong type for the classification feature (string instead of an enum value and int instead of string). Before change, it would give this errorWith pydantic validation it gives this error (catching the name being an int as well)
Type of change
Please delete options that are not relevant.
All Submissions