Conversation
mihhail-m
reviewed
Apr 3, 2025
4e7200e to
3e47710
Compare
Gabefire
reviewed
Apr 3, 2025
| ) | ||
|
|
||
| # Add a small delay to ensure invite is created | ||
| time.sleep(1) |
Collaborator
There was a problem hiding this comment.
This might make it finicky is their any way we could make this behave more sync? Worse case a retry loop
Collaborator
There was a problem hiding this comment.
Simple one something like time.sleep 5 seconds check if not there retry again up to 3 times
Collaborator
There was a problem hiding this comment.
I only mention because ive fix test with this sort of logic. Its annoying when they become finicky
Contributor
Author
There was a problem hiding this comment.
Thanks for the update. I've removed the pause completely.
6437772 to
19b05a6
Compare
7e37cc8 to
7af08b9
Compare
Gabefire
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a request from Schneider Electric to be able to retrieve the list of pending invitations.
Notes:
This PR fixes a bug when a project is deleted after an invite was sent. To prevent an exception, deleted projects are not listed in
invite.project_rolesFunctions
Example:
Fixes # (issue)
Type of change
Please delete options that are not relevant.
All Submissions
New Feature Submissions
Changes to Core Features