[CCV-4605] Add ability to specify relationship constraints #1969#1992
Merged
[CCV-4605] Add ability to specify relationship constraints #1969#1992
Conversation
mrobers1982
requested changes
Jul 2, 2025
| if tool_cls is not None: | ||
| return tool_cls | ||
| if tool_type == Tool.Type.RELATIONSHIP: | ||
| return RelationshipTool |
Contributor
There was a problem hiding this comment.
Can you add this map_tool_type_to_tool_cls for consistency?
Contributor
There was a problem hiding this comment.
Moving it there looks to create a circular dependency, so we will just go with above.
This reverts commit 3fcfce9.
mrobers1982
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
All Submissions
New Feature Submissions
Changes to Core Features