Add multiple cells

[RedenticDev]

Let me know what you think, probably gonna upload some more cells later as this repo is very useful.

[LacertosusRepo]

I really like the addition of the icon to the AnimatedTitleView, but it should be a part of the same class not in a separate file. I've attached source files that combines the classes.

• LDAnimatedTitleView.zip

[RedenticDev]

Working on it. Side note: why do you use categories instead of declaring properties or ivars?

[RedenticDev]

This should work, I let you checking out. I didn't test that. Just remove the "second part" of the .h file to fix the merge conflict.

[LacertosusRepo]

Side note: why do you use categories instead of declaring properties or ivars?

What do you mean?

[RedenticDev]

Side note: why do you use categories instead of declaring properties or ivars?

What do you mean?

You're using curly braces in @implementation and I thought it was a class extension, my bad. But what are the upsides of doing so on some codes I've seen? People were using @interface in their .h, extension with their variables in the .m, and @implementation in .m too

[LacertosusRepo]

Declaring ivars in the implementation just defaults them to @private vs the interface being @public. It's just preference to me, I try to only use properties if something need access to a value/object.

[RedenticDev]

What's the point of using ivars then?

[LacertosusRepo]

What's the point of using ivars then?

Because nothing needs access to the variables. They are just for this class so there's no point in making properties.

[RedenticDev]

Okay I see thanks. I let you check the PR.

[LacertosusRepo]

Some ideas here about the constraints:

The stackview wont be centered on the X axis with the current constraints. All edges should be anchored or it could be centered with both centerX/centerY anchors.

Using edge anchors would also allow you to get rid of the heightAnchor by constraining the top anchor of the stackview to the title label's gradient's top anchor and the bottom anchor to the subtitle's bottom anchor:

[self.stackView.topAnchor constraintEqualToAnchor:self.gradientView.topAnchor],
[self.stackView.bottomAnchor constraintEqualToAnchor:self.titleLabel.bottomAnchor],

The gradient's height/width anchors should just be equal to the title label's anchors: I see that the label is used as the mask.

EDIT: Fixed some incorrect suggestions.

[RedenticDev]

For the first part, the stack view isn't aimed to be centered on X, its left padding with a small indent of 25 (to leave some space and not stick it to the left border) looks great. In my opinion if the end user/developer wants it centered it's easily doable, but it's not the aim of my implementation.

For your edge anchors suggestion, it should work too, but I'm not sure if it'd break the gradient or the scrolling effect I made. Also I may add that it works great as-is, thus I don't get the point of changing that.

If you're really sure that it won't break the current look & feel of the banner, and that a change might be better in terms of performance or code practices, I'm open to any change. But honestly I don't see why anything should be changed on constraints' side with the current implementation.