chore: extract tool configs and switch to static version#54
chore: extract tool configs and switch to static version#54theveenrok merged 17 commits intodevelopfrom
Conversation
fc5a1a0 to
d797c6d
Compare
be279b7 to
c114f63
Compare
📝 WalkthroughWalkthroughExtracts tool-specific settings from Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✏️ Tip: You can disable this entire section by setting Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
Caution Docstrings generation - FAILED No docstrings were generated. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.coveragerc:
- Around line 4-10: The INI-style .coveragerc is using quoted values which will
be taken literally; update the [paths] source entry and the [report]
exclude_lines value by removing the surrounding double quotes so source =
src/app and exclude_lines includes pragma: not covered (i.e., replace the quoted
"src/app" and the quoted "pragma: not covered" with unquoted values) so the
paths and regex matching behave correctly.
🧹 Nitpick comments (1)
pytest.toml (1)
14-21: Clarify warning handling intent:--disable-warningsvsfilterwarnings = ["error"].There's a potential conflict in warning handling:
- Line 14:
--disable-warningssuppresses warning output in the console- Lines 20-22:
filterwarnings = ["error"]converts warnings into errorsWhile these can technically coexist (warnings become errors but their output is suppressed), the combination seems contradictory. If warnings should fail tests, consider removing
--disable-warningsto see what triggered the failure. If warnings should be ignored, consider removingfilterwarnings = ["error"].
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (8)
.coveragercpyproject.tomlpytest.tomlsrc/app/__init__.pysrc/app/__meta__.pytests/test_version.pytowncrier.tomlty.toml
💤 Files with no reviewable changes (3)
- src/app/init.py
- tests/test_version.py
- src/app/meta.py
🔇 Additional comments (4)
ty.toml (1)
1-5: LGTM!The ty configuration is correctly extracted with the source directories properly specified.
pyproject.toml (1)
1-15: Verify that removing[build-system]is intentional.The
[build-system]section has been removed, which means standard Python packaging tools (pip install .,python -m build) won't work. This is fine if the project is a pure application deployed via other means (e.g., Docker, uv run), but could be a problem if the package needs to be installed or distributed.towncrier.toml (2)
7-40: LGTM!The change type definitions are comprehensive and well-organized, covering the standard categories for changelog entries.
1-5: No action needed. The[tool.towncrier]table format is correct for standalonetowncrier.tomlfiles according to official towncrier documentation. This format is used in both standalonetowncrier.tomlandpyproject.tomlconfigurations.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
Summary
Moved configuration for auxiliary tools out of
pyproject.tomlinto dedicated files, replaced the dynamic project version with a static one, and removed the[build-system]section since the project is not published as an external dependency.Type
Changes
uv,ty,pytest,coverage, andtowncrierinto separate config files.pyproject.toml.[build-system]section frompyproject.toml.src/app/__meta__.pyand the import of__version__fromsrc/app/__init__.py.Verification
just checkDocs
Tests
Changelog
changelog.d/Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.