This repository was archived by the owner on Mar 31, 2025. It is now read-only.
atomic record update without sql#11
Open
Jan-Hettich wants to merge 3 commits intoLasVegasRubyGroup:masterfrom
Jan-Hettich:update_without_sql
Open
atomic record update without sql#11Jan-Hettich wants to merge 3 commits intoLasVegasRubyGroup:masterfrom Jan-Hettich:update_without_sql
Jan-Hettich wants to merge 3 commits intoLasVegasRubyGroup:masterfrom
Jan-Hettich:update_without_sql
Conversation
…d using update! instead of raw sql
…liminated method_missing, which was causing an issue, because activerecord itself uses method_missing while copying attributes during update; temporarily got tests passing by implementing title and description methods explicitly in the Topic class; however, this will be replaced in future by meta-programming to add the methods from the extension class into the base class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced handwritten sql update with call to ActiveRecord update! Replaced problematic method_missing with forwarding methods created through meta-programming (creating accessors on the base class for columns in the extension class).