-
Notifications
You must be signed in to change notification settings - Fork 84
Added More Fluid Cans mod (100mB and 250mB cans) #675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: Astral-Experimental
Are you sure you want to change the base?
Added More Fluid Cans mod (100mB and 250mB cans) #675
Conversation
> Copper Cans are super useful and it sucks there's no gem or brick variants Removed Copper Cans recipe from More Fluid Cans and hid it from REI > Tconstructs copper can already exists Added cans to the reward tables in ch2/3 > Adds a way for the player to find out about them, also just a nice reward
The-Shortman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks fine, I haven't tested though. If you can leave a link to a GitHub repo for the mod in the PR somewhere that'd be great.
I do like the idea of more ways to carry common fluid amounts.
> Now without dashes, as per Short's suggestion!
Fixed doncrete_stairs lang key > Seemed like a mistake, was also a dupe key
The-Shortman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (blocking): The namespaces in Astral have not yet been changed to reflect the new mod ID.
|
Omg that's right I completely forgot about that |
The-Shortman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
> Adds a bit of spice if that makes sense
|
Please pull changes from Astral-Experimental in order for the packwiz check to work again. |
What does this pull request do? [REQUIRED]
Adds the More Fluid Cans mod
Changes made [REQUIRED]
Added the More Fluid Cans mod
Removed Copper Cans recipe from More Fluid Cans and hid it from REI
Added cans to the reward tables in ch2/3
Additional Information [OPTIONAL]
The added cans are the Emerald Can (100mB), Brick Can (250mB) and it's own Copper Can (111,(1)mB. Removed in favor of the TC variant)
The GitHub repo is here