Revert to simpler approach without compiler flag modification

[stayaway245]

No description provided.

[mentatbot]

I'm getting to work. See my steps and track my cost here.

• Wake on any new activity.
  _{I always see new activity while actively working. When paused, I'll only respond when tagged unless this box is checked.}

[mentatbot]

I've reviewed the changes in this PR which simplifies the iOS build configuration in the GitHub Actions workflow.

Changes overview

• Removed the complex approach of dynamically creating a CMake toolchain file (cmake/ios-toolchain.cmake)
• Replaced with direct CMake command-line arguments for the iOS build
• Simplified handling of compiler and linker flags

Analysis

This change appears to be beneficial for several reasons:

1. Reduced complexity: The new approach is more straightforward and easier to understand
2. Avoided quoting issues: Directly specifying CMake arguments eliminates the shell quoting/escaping issues that can happen when generating files with embedded quotes
3. Better maintainability: The direct approach makes the build process more transparent

Note

I noticed there's duplicate code for checking for Dobby in the build script - it's setting the Dobby flags in EXTRA_CMAKE_ARGS twice:

• Once before the "simpler approach" comment
• Again right after it

This duplication doesn't cause issues in the current code but could potentially lead to confusion in future maintenance. Consider removing one of these duplicate sections in a future PR.

The build now correctly passes the iOS architecture, deployment target, and feature flags directly to CMake, which is a cleaner approach than using a toolchain file for this purpose.