v3.3.0 - SUmask and Landlock feature #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Some code refactor was done, * Some arbitrary values removed. * "inherited" value removed from bounding, authentication, execinfo, they were completely useless. * Implemented chsr syntax for execinfo and umask
test: enhance coverage for setuid/setgid and capabilities test: improve duration conversion error handling
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
==========================================
- Coverage 76.14% 74.75% -1.40%
==========================================
Files 33 36 +3
Lines 4595 5134 +539
==========================================
+ Hits 3499 3838 +339
- Misses 1096 1296 +200
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…r user and setgid set deserialization
- Split `edit_config` into a public wrapper and a private `edit_config_internal` function to allow dependency injection. - The internal function now accepts `BufRead` for input, `Write` for output, and a custom editor path string. - Added a `tests` module to `src/chsr/cli/editor.rs`. - Implemented `test_edit_config_success` to verify successful configuration updates using a mock editor script. - Implemented `test_edit_config_abort` to verify the abort flow.
…rove test coverage
…enhance FAccess serialization
… and rpassword modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new version introduces v3.3.0 for adding UMask option in config, and landlock enforcement feature.
Copilot slop (actually somewhat relevant) :
This pull request introduces support for a configurable
umaskoption in the execution environment, enhances configuration flexibility, and refines several existing option enums to remove legacy/inherited values. It also updates documentation to reflect these changes and adds comprehensive tests for the newumasktype. Version numbers are incremented to reflect these significant changes.New Feature:
umaskOptionumaskfield (SUMask) to the core option struct (Opt), allowing the execution environment's file creation mask to be set per role or configuration. Includes full serde (serialization/deserialization) support and extensive tests for correct parsing and formatting. (rar-common/src/database/options.rs,rar-common/Cargo.toml,.cargo/config.toml,book/src/chsr/README.md,book/src/chsr/file-config.md) [1] [2] [3] [4] [5] [6] [7]Configuration and Defaults Improvements
Optstruct to use constants and environment values directly, improving clarity and maintainability. Now, all default values (including the newumask) are set via a centralized method. (rar-common/src/database/options.rs) [1] [2]SConfigandSRolestructs to deriveDefault, ensuring easier instantiation and safer usage. (rar-common/src/database/structs.rs) [1] [2]Enum and Policy Refinements
SPrivileged,SBounding, andSAuthenticationenums, leaving only currently supported policies. Updated parsing logic and documentation accordingly. (rar-common/src/database/options.rs,book/src/chsr/README.md) [1] [2] [3] [4] [5]umaskoption. (book/src/chsr/README.md,book/src/chsr/file-config.md) [1] [2]Version Bumps
3.3.0to reflect the addition of theumaskfeature and related breaking changes. (Cargo.toml,rar-common/Cargo.toml) [1] [2] [3]Testing Enhancements
SUMasktype, covering conversion, serialization, deserialization, and edge cases. (rar-common/src/database/options.rs)