feat: introduce legacy patcher system and mod management API with frontend integration #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntend integration
Crauzer
requested changes
Dec 17, 2025
| let settings = settings | ||
| .0 | ||
| .lock() | ||
| .map_err(|e| AppError::InternalState(e.to_string()))? |
Member
There was a problem hiding this comment.
Instead of doing map_err we should implement a new AppError variant for when the Mutex lock fails.
Comment on lines
-42
to
-45
| #[error("Failed to begin hook")] | ||
| HookFailed, | ||
| #[error("Hook initialization timed out")] | ||
| HookTimeout, |
Member
There was a problem hiding this comment.
Don't remove this, it's for the new patcher
| match run_patcher_loop( | ||
| &dll_path, | ||
| &config_path, | ||
| &overlay_root_for_thread, |
Member
There was a problem hiding this comment.
config_path in new patcher is the equivalent of the overlay path, we need to make the backend implementation abstract enough so that it can support the current (legacy) patcher and the new one as well.
Comment on lines
-157
to
-200
| let tid = loop { | ||
| if stop_flag.load(Ordering::SeqCst) { | ||
| return Err(PatcherLoopError::Stopped); | ||
| } | ||
| match api.find() { | ||
| Some(tid) => break tid.get(), | ||
| None => api.sleep(100), | ||
| } | ||
| }; | ||
|
|
||
| tracing::info!("Found League process, thread id: {}", tid); | ||
|
|
||
| let count_before = api.hook_count(); | ||
| let hook = api.hook_begin(tid); | ||
| if hook == 0 { | ||
| return Err(PatcherLoopError::HookFailed); | ||
| } | ||
|
|
||
| let mut time_remaining = timeout_ms as i64; | ||
| loop { | ||
| if stop_flag.load(Ordering::SeqCst) { | ||
| api.hook_end(tid, hook); | ||
| return Err(PatcherLoopError::Stopped); | ||
| } | ||
|
|
||
| if time_remaining <= 0 { | ||
| api.hook_end(tid, hook); | ||
| return Err(PatcherLoopError::HookTimeout); | ||
| } | ||
|
|
||
| api.hook_continue(tid, hook); | ||
| api.sleep(HOOK_STEP_MS); | ||
|
|
||
| if api.hook_count() != count_before { | ||
| tracing::info!("Hooks applied successfully"); | ||
| api.hook_end(tid, hook); | ||
| break; | ||
| tracing::info!("Waiting for game to start (polling cslol_find)..."); | ||
| let mut last_wait_log = Instant::now(); | ||
| let tid = loop { | ||
| if stop_flag.load(Ordering::SeqCst) { | ||
| return Err(PatcherLoopError::Stopped); | ||
| } | ||
| match api.find() { | ||
| Some(tid) => break tid.get(), | ||
| None => { | ||
| if last_wait_log.elapsed() >= Duration::from_secs(5) { | ||
| tracing::info!("Still waiting for game process..."); | ||
| last_wait_log = Instant::now(); | ||
| } | ||
| api.sleep(100); | ||
| } | ||
| } | ||
| }; | ||
|
|
||
| tracing::info!("Game found (thread id: {})", tid); | ||
|
|
||
| tracing::info!( | ||
| "Applying hook (timeout_ms={}, step_ms={})...", | ||
| timeout_ms, | ||
| HOOK_STEP_MS | ||
| ); | ||
| api.hook(tid, timeout_ms, HOOK_STEP_MS)?; | ||
| tracing::info!("Hook applied, waiting for game to exit..."); | ||
|
|
||
| while !stop_flag.load(Ordering::SeqCst) { | ||
| match api.find() { | ||
| Some(current) if current.get() == tid => { | ||
| while let Some(msg) = api.log_pull() { | ||
| tracing::info!("[cslol] {}", msg); | ||
| } | ||
| api.sleep(1000); | ||
| } | ||
| _ => break, | ||
| } | ||
| } | ||
|
|
||
| time_remaining -= HOOK_STEP_MS as i64; | ||
| tracing::info!("Game exited, returning to wait loop"); | ||
| } | ||
|
|
||
| tracing::info!("Hook session completed"); | ||
| Ok(()) |
Member
There was a problem hiding this comment.
Do not remove the new patcher hook routine implementation, instead move this code from the command file into the relevant patcher module and make it abstract at the point of calling - this file, so we support multiple patcher implementations.
| Ok(Self { | ||
| cslol_init: *lib | ||
| .get(b"cslol_init") | ||
| .map_err(|e| PatcherError::MissingSymbol { |
Member
There was a problem hiding this comment.
We can just use the ? operator here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.