This repository was archived by the owner on May 30, 2022. It is now read-only.
Draft
Conversation
valpinkman
suggested changes
Jun 2, 2020
| - name: config gcc | ||
| if: runner.os == 'Linux' | ||
| run: sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-7 700 --slave /usr/bin/g++ g++ /usr/bin/g++-7 | ||
| - name: prebuild for electron 8.1 |
Contributor
There was a problem hiding this comment.
Can you update 8.1 to 9 ? Check on master we merged a new version
Contributor
Author
There was a problem hiding this comment.
Will do, no idea why it has not updated yet
Contributor
Author
There was a problem hiding this comment.
Not staging the changes is one answer....
gagbo
force-pushed
the
coin-int-specific-CI
branch
2 times, most recently
from
e4c9af2 to
44c8dde
Compare
valpinkman
reviewed
Jun 19, 2020
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| matrix: | ||
| os: [ubuntu-16.04, macos-latest, windows-2016] |
Contributor
There was a problem hiding this comment.
just a question, why not using ubuntu-latest and windows-latest ?
Contributor
There was a problem hiding this comment.
I suggest to always use well-defined runners instead of xxx-latest to avoid to break CI in future latest release platforms
added 2 commits
June 25, 2020 18:00
For coin integration branches, it is necessary to trigger this push to help testers down the road (Live-common CLI tests). Any push/merge on int-COIN will push a new @ledgerhq/ledger-core@COIN so that live-common-only users hopefully don't need a full GCC toolchain to test the current version in CLI. It does not not run the yarn version on the Action. yarn version is actually a hidden git commit so it will trigger an infinite loop (actually it fails because there are no credentials)
gagbo
force-pushed
the
coin-int-specific-CI
branch
from
be5347b to
da7a769
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
For coin integration branches, it is necessary to trigger this push to
help testers down the road (Live-common CLI tests).
Features
Any push/merge on int-COIN will push a new @ledgerhq/ledger-core@COIN so
that live-common-only users hopefully don't need a full GCC toolchain to
test the current version in CLI.
Notes
No Yarn version run during the action
yarn version is actually a hidden git commit so it may trigger an
infinite loop (actually it fails because there are no credentials)
Crendentials
The name of the CI secret is currently hardcoded to the name used in CoinInt specific CI. The exact name is not fixed by any means ; but using a different name for the secret between the 2 forks has the nice advantage of preventing unwanted publishes from one repo or another.