You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on May 30, 2022. It is now read-only.
It fixes compile error. A compile error was found be @gagbo
Basically, we've updated some preferences related binding on the libcore side. we should also update some corresponding stuff on node side.
All changes in this PR are auto generated.
The related PR on lib core : LedgerHQ/lib-ledger-core#665
More detail related to the compile error:
we've changed NJSPreferencebackendCpp into NJSPreferencebackend
if we launch the auto generate binding script on libcore side. It copies NJSPreferencebackend to the src folder
It has both NJSPreferencebackendCpp.cpp and NJSPreferencebackend.cpp and these two files contains same class and it causes an error
So the NJSPreferencebackendCpp.cpp should be removed
but if you don't need to use the updated binding from libcore
there is no compile error. what I do in this PR is to update the binding on node side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.