Cubic Chunks Compatibility #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
DataManagerthat's dedicated to syncing cube data and clarifies the existingPacketDataManager's behaviour when CC is present.CC was changed to use
S23PacketBlockChangepackets to sync individual block changes. Previously it side-stepped S23 entirely and used a custom packet. It still uses a custom packet, but the packet contains a list of S23 packets. I swapped to S23 to support things like FluidLogged since FL mixins a field into S23.CC uses a custom packet for syncing cubes but I didn't want to hack everything to use S21 and S22 since it would've broken several contracts in the MC code.