feat: Timeline custom filters #5

LeleDallas · 2025-11-21T08:05:23Z

This pull request introduces advanced filtering capabilities and a robust multi-tier data fetching strategy to the GitHub Activity extension, along with major improvements to reliability, user experience, and code maintainability. The changes span both documentation and implementation, providing users with granular control over which pull requests are displayed and ensuring the extension remains functional even if GitHub’s web interface changes.

Preview

List of changes proposed in this pull request

Added support for filtering pull requests by date range, status (open/draft), author type (authored, assigned, others), and result limits, with persistent settings synced across devices and a one-click reset to defaults.
Introduced a clean popup UI for filter controls, visual status indicators for active filters, and automatic theme detection for dark mode support.
Implemented a multi-tier data fetching strategy: first scraping the GitHub web interface, then falling back to the Events API and finally the Search API, ensuring maximum reliability and robust error handling.
Enhanced the API layer with dynamic query construction based on user filters, including new helper functions for building search URLs and API queries

Copilot

Pull Request Overview

This PR introduces advanced filtering capabilities for pull requests with a comprehensive multi-tier data fetching strategy. The implementation adds a popup UI for filter customization, dynamic query construction for GitHub's search APIs, and robust fallback mechanisms for data retrieval.

Added custom filter controls for date range, PR status, author type, and result limits with persistent storage
Implemented multi-tier data fetching: web scraping → Events API → Search API with graceful fallbacks
Enhanced UI with dark mode support, status indicators, and GitHub-native styling

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 14 comments.

Show a summary per file

File	Description
firefox/popup.js, chrome/popup.js	New filter management logic with validation and storage
firefox/popup.html, chrome/popup.html	Filter UI with GitHub-themed styling and dark mode support
firefox/content.js, chrome/content.js	Refactored to support dynamic filters and multi-tier fetching
firefox/api.js, chrome/api.js	Added query builders and Events API fallback
firefox/ui.js, chrome/ui.js	Updated empty state message to reflect filters
README.md	Documentation updates for new filtering features

Comments suppressed due to low confidence (2)

firefox/content.js:15

Unused variable storage.

  const storage = typeof browser !== 'undefined' ? browser.storage : chrome.storage;

firefox/api.js:232

The value assigned to dateString here is unused.

          dateString = dateElement.getAttribute('datetime') || 
                      dateElement.getAttribute('title') ||
                      dateElement.textContent;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-21T08:12:08Z

firefox/popup.js

+  if (typeof chrome !== 'undefined' && chrome.tabs) {
+    chrome.tabs.query({active: true, currentWindow: true}, function(tabs) {
+      if (tabs[0] && tabs[0].url && tabs[0].url.includes('github.com')) {
+        chrome.tabs.executeScript(tabs[0].id, {


The chrome.tabs.executeScript API is deprecated in Manifest V3 and should be replaced with chrome.scripting.executeScript. If targeting Manifest V3, update this to use the scripting API with proper permissions.

Copilot · 2025-11-21T08:12:09Z

chrome/popup.js

+  if (typeof chrome !== 'undefined' && chrome.tabs) {
+    chrome.tabs.query({active: true, currentWindow: true}, function(tabs) {
+      if (tabs[0] && tabs[0].url && tabs[0].url.includes('github.com')) {
+        chrome.tabs.executeScript(tabs[0].id, {


The chrome.tabs.executeScript API is deprecated in Manifest V3 and should be replaced with chrome.scripting.executeScript. If targeting Manifest V3, update this to use the scripting API with proper permissions.

Copilot · 2025-11-21T08:12:09Z

firefox/content.js

-  // Fetch user PRs by scraping GitHub's issues page (same as web interface)
-  const allPRs = await fetchPRsFromWebInterface(username);
+  // Cross-browser storage API
+  const storage = typeof browser !== 'undefined' ? browser.storage : chrome.storage;


Inconsistent browser API usage. Line 15 defines a storage variable for cross-browser compatibility, but line 20 directly uses browser.storage instead of the defined storage variable, making the fallback mechanism ineffective.

Copilot · 2025-11-21T08:12:09Z

firefox/content.js

+  // Load user filters
+  let userFilters;
+  try {
+    const result = await browser.storage.sync.get({ filters: null });


Inconsistent browser API usage. Line 15 defines a storage variable for cross-browser compatibility, but line 20 directly uses browser.storage instead of the defined storage variable, making the fallback mechanism ineffective.

Suggested change

const result = await browser.storage.sync.get({ filters: null });

const result = await storage.sync.get({ filters: null });

Copilot · 2025-11-21T08:12:09Z

firefox/popup.js

+};
+
+// Theme detection function
+function initializeThemeDetection() {


The initializeThemeDetection function is defined but never called. Either invoke this function in the DOMContentLoaded event handler (line 257) or remove it if theme detection is handled automatically by CSS media queries.

Copilot · 2025-11-21T08:12:10Z

chrome/popup.html

+                fill="black"></path>
        </svg>
-        <p class="text">Created by LeleDallas</p>
+        <p class="text" style="color: black;">Created by LeleDallas</p>


Hardcoded black color in inline styles overrides theme CSS variables, breaking dark mode support. The SVG path and text will remain black in dark mode. Remove the inline styles and use CSS variables like var(--color-fg-default) for proper theme support.

Copilot · 2025-11-21T08:12:11Z

firefox/api.js

+    // Handle status filters
+    const statusFilters = [];
+    if (filters.showOpen && !filters.showDraft) {
+      statusFilters.push('state:open', '-is:draft'); // Exclude drafts


[nitpick] The status filter logic in buildGitHubSearchURL uses a different implementation pattern than the chrome version. Firefox pushes two separate array elements ('state:open', '-is:draft') while Chrome pushes them as separate statements. Consider using the same pattern (separate push statements) for consistency across both browser implementations.

Suggested change

statusFilters.push('state:open', '-is:draft'); // Exclude drafts

statusFilters.push('state:open'); // Exclude drafts

statusFilters.push('-is:draft');

Copilot · 2025-11-21T08:12:11Z

firefox/api.js

+        // Try to extract date information from the page
+        const dateElement = item.querySelector('time, [datetime], .opened-by');
+        let dateString = null;
+        if (dateElement) {
+          dateString = dateElement.getAttribute('datetime') || 
+                      dateElement.getAttribute('title') ||
+                      dateElement.textContent;
+        }


The extracted dateString variable is never used after being set. Either remove this code block or use the date information for filtering or sorting purposes.

Copilot · 2025-11-21T08:12:11Z

firefox/api.js

+// Get the effective max results value
+function getMaxResults(filters) {
+  if (filters.maxResults === 'custom') {
+    return Number.parseInt(filters.customMaxResults) || 8;


Missing radix parameter in Number.parseInt. Always specify the radix (10) to avoid potential parsing issues: Number.parseInt(filters.customMaxResults, 10).

Suggested change

return Number.parseInt(filters.customMaxResults) || 8;

return Number.parseInt(filters.customMaxResults, 10) || 8;

Copilot · 2025-11-21T08:12:11Z

chrome/api.js

+// Get the effective max results value
+function getMaxResults(filters) {
+  if (filters.maxResults === 'custom') {
+    return Number.parseInt(filters.customMaxResults, 10) || 8;


Inconsistent implementation between firefox and chrome versions. Firefox version (line 450) is missing the radix parameter while Chrome version correctly includes it. Ensure both implementations are identical.

m-aguilar9

LGTM! Thanks for incorporating the filtering feature!

LeleDallas · 2025-12-15T10:36:19Z

LGTM! Thanks for incorporating the filtering feature!

Glad that helped!😄
Before merging, I’ll add a version tagging system with a changelog to make it more structured😉

LeleDallas added 3 commits November 21, 2025 08:44

chore: remove ui filters

4e17b8c

feat: PR filters

eaff33c

chore: update readme

83e4c10

LeleDallas self-assigned this Nov 21, 2025

LeleDallas added enhancement New feature or request Chrome Something related to google chrome labels Nov 21, 2025

LeleDallas linked an issue Nov 21, 2025 that may be closed by this pull request

timeline of cards #1

Open

LeleDallas added the Firefox Something related to google firefox label Nov 21, 2025

LeleDallas mentioned this pull request Nov 21, 2025

timeline of cards #1

Open

LeleDallas requested a review from Copilot November 21, 2025 08:08

Copilot started reviewing on behalf of LeleDallas November 21, 2025 08:08 View session

Copilot finished reviewing on behalf of LeleDallas November 21, 2025 08:09

Copilot AI reviewed Nov 21, 2025

View reviewed changes

m-aguilar9 approved these changes Dec 14, 2025

View reviewed changes

	const result = await browser.storage.sync.get({ filters: null });
	const result = await storage.sync.get({ filters: null });

	statusFilters.push('state:open', '-is:draft'); // Exclude drafts
	statusFilters.push('state:open'); // Exclude drafts
	statusFilters.push('-is:draft');

	return Number.parseInt(filters.customMaxResults) \|\| 8;
	return Number.parseInt(filters.customMaxResults, 10) \|\| 8;

feat: Timeline custom filters #5

Are you sure you want to change the base?

feat: Timeline custom filters #5

Conversation

LeleDallas commented Nov 21, 2025

Preview

List of changes proposed in this pull request

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

m-aguilar9 left a comment

Choose a reason for hiding this comment

Uh oh!

LeleDallas commented Dec 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants