add regex validator for project test name#589
Open
Syuparn wants to merge 1 commit intoLexpedite:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test name validator to prevent project crashes.
Since test names cannot have special characters, creating a new test with a special character name causes an error.
Furthermore, once a test with an invalid name has been created in a project, every page in the project throws the same error and the project cannot be used anymore.
(before: creating a new test with a special character name)

(before: top page in the project throws an error)

This PR adds a validator to the
BlawxTestmodel to validate its name before saving it so that any other pages in the project can be accessed afterwards.(after: a new test with a special character name is validated before saved)

(after: top page in the project can be accessed)
