Conversation
hartig
reviewed
Jan 26, 2026
Member
hartig
left a comment
hartig
left a comment
There was a problem hiding this comment.
Here are comments on the first bunch of files in this PR (the files under ./hefquin-access/ and under ./hefquin-base/)
hefquin-access/src/main/java/se/liu/ida/hefquin/federation/access/impl/req/RESTRequestImpl.java
Outdated
Show resolved
Hide resolved
hefquin-access/src/main/java/se/liu/ida/hefquin/federation/access/impl/req/RESTRequestImpl.java
Outdated
Show resolved
Hide resolved
...-access/src/main/java/se/liu/ida/hefquin/federation/catalog/FederationDescriptionReader.java
Outdated
Show resolved
Hide resolved
...-access/src/main/java/se/liu/ida/hefquin/federation/catalog/FederationDescriptionReader.java
Outdated
Show resolved
Hide resolved
...-access/src/main/java/se/liu/ida/hefquin/federation/catalog/FederationDescriptionReader.java
Outdated
Show resolved
Hide resolved
hefquin-access/src/main/java/se/liu/ida/hefquin/federation/members/RESTEndpoint.java
Outdated
Show resolved
Hide resolved
hefquin-access/src/main/java/se/liu/ida/hefquin/federation/members/impl/RESTEndpointImpl.java
Outdated
Show resolved
Hide resolved
...in-base/src/main/java/se/liu/ida/hefquin/jenaext/sparql/syntax/ElementServiceWithParams.java
Outdated
Show resolved
Hide resolved
...java/se/liu/ida/hefquin/jenaext/sparql/lang/sparql_12_hefquin/ParserSPARQL12HeFQUINTest.java
Outdated
Show resolved
Hide resolved
hartig
requested changes
Jan 28, 2026
hefquin-access/src/main/java/se/liu/ida/hefquin/federation/access/impl/req/RESTRequestImpl.java
Show resolved
Hide resolved
...-access/src/main/java/se/liu/ida/hefquin/federation/catalog/FederationDescriptionReader.java
Outdated
Show resolved
Hide resolved
...da/hefquin/engine/queryplan/executable/impl/ops/ExecOpLookupJoinViaWrapperWithParamVars.java
Show resolved
Hide resolved
...da/hefquin/engine/queryplan/executable/impl/ops/ExecOpLookupJoinViaWrapperWithParamVars.java
Show resolved
Hide resolved
...da/hefquin/engine/queryplan/executable/impl/ops/ExecOpLookupJoinViaWrapperWithParamVars.java
Outdated
Show resolved
Hide resolved
...src/main/java/se/liu/ida/hefquin/engine/queryplan/utils/TextBasedLogicalPlanPrinterImpl.java
Outdated
Show resolved
Hide resolved
...efquin/engine/queryplan/executable/impl/ops/ExecOpLookupJoinViaWrapperWithParamVarsTest.java
Outdated
Show resolved
Hide resolved
...efquin/engine/queryplan/executable/impl/ops/ExecOpLookupJoinViaWrapperWithParamVarsTest.java
Outdated
Show resolved
Hide resolved
hefquin-engine/src/test/java/se/liu/ida/hefquin/engine/EngineTestBase.java
Outdated
Show resolved
Hide resolved
…alog/FederationDescriptionReader.java Co-authored-by: Olaf Hartig <olaf.hartig@liu.se>
…an/executable/impl/ops/ExecOpLookupJoinViaWrapperWithParamVars.java Co-authored-by: Olaf Hartig <olaf.hartig@liu.se>
…an/executable/impl/ops/ExecOpLookupJoinViaWrapperWithParamVarsTest.java Co-authored-by: Olaf Hartig <olaf.hartig@liu.se>
…an/utils/TextBasedLogicalPlanPrinterImpl.java Co-authored-by: Olaf Hartig <olaf.hartig@liu.se>
…estBase.java Co-authored-by: Olaf Hartig <olaf.hartig@liu.se>
…upJoinViaWrapperWithParamVars
hartig
approved these changes
Jan 30, 2026
Member
hartig
left a comment
hartig
left a comment
There was a problem hiding this comment.
Looks all good now! Is there anything else you want to do in this PR? Otherwise, I merge it.
Collaborator
Author
No, I think we got it :) Please merge it! |
Member
|
Excellent! Thanks a lot for the contribution! Let me know when you have something else; we can also set up a call if you want to discuss something (but notice that I will be on vacation next week -- vi ska åka till fjällen :-) |
hartig
added a commit
that referenced
this pull request
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #492 for discussions.